On Sun, 19 Feb 2023 22:11:09 GMT, Thiago Milczarek Sayao <tsa...@openjdk.org>
wrote:
>> Simple PR to remove gtk2 library compilation and loading.
>
> Thiago Milczarek Sayao has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Remove unused option
I went ahead and added the minimum version check. I can rollback if unwanted.
I've compiled it simulating a minimum. The output is:
java @build/run.args -Djdk.gtk.verbose=true -jar
apps/samples/Ensemble8/dist/Ensemble8.jar
checking GTK version 3
trying GTK library libgtk-3.so.0
using GTK library version 3 set libgtk-3.so.0
Glass GTK library to load is glassgtk3
ERROR: Minimum GTK version required is 3.24.34. System has 3.24.33.
Exception in thread "main" java.lang.reflect.InvocationTargetException
at
java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:119)
at java.base/java.lang.reflect.Method.invoke(Method.java:578)
at
java.base/sun.launcher.LauncherHelper$FXHelper.main(LauncherHelper.java:1081)
Caused by: java.lang.UnsupportedOperationException: Incompatible GTK 3 version.
at
javafx.graphics@21-internal/com.sun.glass.ui.gtk.GtkApplication.<init>(GtkApplication.java:179)
at
javafx.graphics@21-internal/com.sun.glass.ui.gtk.GtkPlatformFactory.createApplication(GtkPlatformFactory.java:40)
at
javafx.graphics@21-internal/com.sun.glass.ui.Application.run(Application.java:146)
at
javafx.graphics@21-internal/com.sun.javafx.tk.quantum.QuantumToolkit.startup(QuantumToolkit.java:290)
at
javafx.graphics@21-internal/com.sun.javafx.application.PlatformImpl.startup(PlatformImpl.java:292)
at
javafx.graphics@21-internal/com.sun.javafx.application.PlatformImpl.startup(PlatformImpl.java:162)
at
javafx.graphics@21-internal/com.sun.javafx.application.LauncherImpl.startToolkit(LauncherImpl.java:651)
at
javafx.graphics@21-internal/com.sun.javafx.application.LauncherImpl.launchApplicationWithArgs(LauncherImpl.java:409)
at
javafx.graphics@21-internal/com.sun.javafx.application.LauncherImpl.launchApplication(LauncherImpl.java:363)
at
java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
... 2 more
-------------
PR: https://git.openjdk.org/jfx/pull/999
