On Fri, 24 Feb 2023 00:24:56 GMT, Thiago Milczarek Sayao <tsa...@openjdk.org> wrote:
>> Simple PR to remove gtk2 library compilation and loading. > > Thiago Milczarek Sayao has updated the pull request incrementally with one > additional commit since the last revision: > > Review changes This looks good. Please file the CSR when you get a chance -- take a look at [JDK-8277962](https://bugs.openjdk.org/browse/JDK-8277962) for some ideas. The Specification section of the CSR for this issue should specify the behavior in the three cases in question: Case 1: The application or end user has explicitly requested GTK 2 using the jdk.gtk.version system property. list the new warning message Case 2: Another native library has already loaded the GTK 2 library (an application cannot load both the GTK 2 and GTK 3 libraries in the same process). indicate that a UOE exception will be thrown Case 3: The gtk3 libraries are not available on the system. indicate that a UOE exception will be thrown @johanvos @arapte can one of you be the second reviewer on this? ------------- Marked as reviewed by kcr (Lead). PR: https://git.openjdk.org/jfx/pull/999
