On Thu, 30 Mar 2023 22:06:59 GMT, Marius Hanl <mh...@openjdk.org> wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableRowSkinBase.java >> line 358: >> >>> 356: // Note: We have to determine the pref width here >>> because the add operation above may trigger the skin >>> 357: // creation first, which is what makes it possible to >>> get a correct value here in the first place. >>> 358: width = tableCell.prefWidth(height); >> >> I wonder if it's safe to move this call (one one after else:430) before the >> if statement on line 352? > > I'm not sure if I understand correctly: You mean call > `tableCell.prefWidth(height)` above? > I chose this way so we always call `tableCell.prefWidth(height)` just once, > never twice. actually, please disregard my suggestion: the first `width = tableCell.prefWidth(height);` happens after adding the `tableCell` to a parent, so it is likely would not be an equivalent change. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1077#discussion_r1153839950
