On Sat, 1 Apr 2023 10:02:26 GMT, Marius Hanl <mh...@openjdk.org> wrote:
>> The determined `prefWidth` of a `TableCell` could be `0.0` when a >> `fixedCellSize` is set. >> This happened because the `TableCell` may not have a skin since it was never >> added to the scene graph yet. >> >> The fix is to make sure we get the `prefWidth` after the `TableCell` was >> added to the scene graph. >> That is also the reason why the problem only happened the first time and >> never again after (skin is then already created). > > Marius Hanl has updated the pull request incrementally with two additional > commits since the last revision: > > - JDK-8305248: Added the tests also for TreeTableRow > - JDK-8305248: Improve comments Looks good to me. The PR fixes the issue, a test fails before it and passes with it, and there are some more tests that, even without failing before this PR, are good to have to prevent future issues. ------------- Marked as reviewed by jpereda (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/1077#pullrequestreview-1368690352
