On Fri, 28 Apr 2023 20:24:18 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review comments > > tests/manual/monkey/README.md line 38: > >> 36: Applications stores the user preferences (window position, currently >> selected page, etc.) in `~/.MonkeyTester` directory. >> 37: >> 38: To use a different directory, redefine the `user.home` system property, >> `-Duser.home=<DIR>`. > > I presume this is mainly so you can run multiple MonkeyTester instances > without having them fight over the preferences, right? Maybe add a sentence > to that effect? > > Possible future RFE: This might have other implications (e.g., it will change > the location of the default WebView user data directory). Do you think it > would it be better to have a custom property that, when set, will be used > instead of asking users to change `user.home`? This could be done later if > you think it's worth doing. good idea! with your permission, I'll change to a different property name in another PR (there is also a rather dubious usage of setId() for the purposes of storing the preferences that I'd like to change). ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1097#discussion_r1181808492
