On Mon, 1 May 2023 19:16:31 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Monkey Tester - a JavaFX application designed to support manual ad-hoc >> testing of individual JavaFX controls. Unlike Ensemble, the goal of this >> application is to facilitate manual testing rather than demonstrate the >> capabilities of JavaFX. >> >> Feedback and suggestions are always welcome. >> >>  > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: > > review comments I ran through all of the panels and have three additional suggestions: 1. `ComboBox`: The current two buttons don't seem all that useful. I'm not even sure what, exactly, they do. What would be useful is a way to select the number of items in the list (like there is with ChoiceBox) 2. `ListView`: Changing the selection model or checking / unchecking the "null focus model" option clears the list, which is unexptected. Given that there is a separate "clear list" button, it doesn't seem needed either. 3. `TextField`: The default alignment of BASELINE_RIGHT is unexpected (unless there is a good reason, defaults for properties should match the API default to avoid surprises). Feel free to defer them to [JDK-8307176](https://bugs.openjdk.org/browse/JDK-8307176) if you prefer. If you fix any of them, I'll reapprove. ------------- Marked as reviewed by kcr (Lead). PR Review: https://git.openjdk.org/jfx/pull/1097#pullrequestreview-1408158477
