On Mon, 15 May 2023 16:44:58 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> John Hendrikx has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commits since the last revision: >> >> - Merge branch 'openjdk:master' into feature/css-cache-bug >> - Fix typo >> - Fix bug in CSS caching code that could reset values on unrelated nodes >> >> The bug occurs due to a cache entry being constructed incorrectly when >> the initial node that triggered the cache entry creation has user set >> values. The calculated values for properties with a user set value were >> omitted in the cache entry, and other nodes that later share the same >> entry would incorrectly assume the omitted property was unstyled and >> were therefore reset to their default values. > > modules/javafx.graphics/src/test/java/test/javafx/scene/CssStyleHelperTest.java > line 622: > >> 620: } >> 621: """ >> 622: ); > > is there a chance we would backport this fix (to < java15)? Even if there is, this still shouln't stop us using new language features, should it? Otherwise we can't really use any new feature, as a fix *might* be backported. On the other hand it is also easy to replace this text block when backported. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1072#discussion_r1194170939
