On Mon, 15 May 2023 17:23:45 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:

>> modules/javafx.graphics/src/main/java/javafx/scene/CssStyleHelper.java line 
>> 1185:
>> 
>>> 1183:         if (cssValue != null && 
>>> "inherit".equals(cssValue.getValue())) {
>>> 1184:             style = getInheritedStyle(styleable, property);
>>> 1185:             if (style == null) return SKIP;
>> 
>> minor: could we surround return with { }'s please?  To keep one statement 
>> per line.
>
> It's not my code originally, I only changed the indent here.

Agreed. This code is otherwise unchanged, so I'd prefer it left as is.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1072#discussion_r1194196694

Reply via email to