On Fri, 4 Aug 2023 07:36:08 GMT, Marius Hanl <mh...@openjdk.org> wrote:

>> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/TableViewSkinTest.java
>>  line 79:
>> 
>>> 77:     @Test
>>> 78:     void testInitialColumnResizeNodePositions() {
>>> 79:         TableView<String> tableView = new TableView<>();
>> 
>> question: would it make sense to test with scene scale(s) other than 100%?  
>> just to see if there is no failures with fractional scales?
>> (the asserts would need to use non-0 tolerance)
>
> It probably won't hurt. But since the mismatch is visible even at a normal 
> scale, I didn't bothered to do so.

... as a safeguard for any possible regressions?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1193#discussion_r1293834405

Reply via email to