On Wed, 2 Aug 2023 16:36:47 GMT, Marius Hanl <mh...@openjdk.org> wrote:
> When a table has padding or the `layoutChildren` method inside the table skin > is overridden (and x/y are modified), the drag drag header, column overlay > and column line are not correctly aligned. > > The reason is that the positions were calculated incorrectly. > - **Column overlay and column line** > Always calculate in the x and y from the table. The x and y variables contain > the snapped insets (padding) and possible modifications from subclasses. > - **Drag header** > Calculate the drag x offset local bounds from the parent header (which is > either the parent column header or the root header) > Before, the local bounds were calculated from the table, which will wrongly > calculate in the padding. > We do not want to know the local bounds based of the whole table but of our > header we are in. Tested on MacOS at different scales. The fix looks good to me. ------------- Marked as reviewed by kpk (Committer). PR Review: https://git.openjdk.org/jfx/pull/1193#pullrequestreview-1659586472
