Out of 62 3D tests, 26 tests fail because of minute color differences in edge 
pixels.
These tests are used to verify 3D rendering with different parameters like 
translation, rotation.

So adding little color tolerance will not change the test behavior and allows 
us to use these tests to automatically verify any regression introduced in 3D 
rendering.

Added 5% color tolerance and with this change 23 of these tests pass.

Some sub-tests under below 3 tests continue to fail because of other reasons:
[test/scenegraph/fx3d/camera/fixedeye/PerspectiveCameraFixedEyeIsolateTest.java](file:///Users/jdv/dev/workspace/jfx/jfx-tests/functional/3DTests/build/test.workdir/test/scenegraph/fx3d/camera/fixedeye/PerspectiveCameraFixedEyeIsolateTest.jtr)
[test/scenegraph/fx3d/camera/parallel/ParallelCameraIsolateTest.java](file:///Users/jdv/dev/workspace/jfx/jfx-tests/functional/3DTests/build/test.workdir/test/scenegraph/fx3d/camera/parallel/ParallelCameraIsolateTest.jtr)
[test/scenegraph/fx3d/camera/perspective/PerspectiveCameraIsolateTest.java](file:///Users/jdv/dev/workspace/jfx/jfx-tests/functional/3DTests/build/test.workdir/test/scenegraph/fx3d/camera/perspective/PerspectiveCameraIsolateTest.jtr)

Also i see that some of the camera tests just draw white images, this also 
needs to be verified.
With this change 41 out of 62 3D tests will run properly.

-------------

Commit messages:
 - 8315842: 3D tests fail because of edge pixel differences

Changes: https://git.openjdk.org/jfx-tests/pull/5/files
 Webrev: https://webrevs.openjdk.org/?repo=jfx-tests&pr=5&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8315842
  Stats: 144 lines in 26 files changed: 144 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jfx-tests/pull/5.diff
  Fetch: git fetch https://git.openjdk.org/jfx-tests.git pull/5/head:pull/5

PR: https://git.openjdk.org/jfx-tests/pull/5

Reply via email to