On Mon, 11 Sep 2023 05:21:12 GMT, Jayathirth D V <j...@openjdk.org> wrote:
>> Out of 62 3D tests, 26 tests fail because of minute color differences in >> edge pixels. >> These tests are used to verify 3D rendering with different parameters like >> translation, rotation. >> >> So adding little color tolerance will not change the test behavior and >> allows us to use these tests to automatically verify any regression >> introduced in 3D rendering. >> >> Added 5% color tolerance and with this change 23 of these tests pass. >> >> Some sub-tests under below 3 tests continue to fail because of other reasons: >> [test/scenegraph/fx3d/camera/fixedeye/PerspectiveCameraFixedEyeIsolateTest.java](file:///Users/jdv/dev/workspace/jfx/jfx-tests/functional/3DTests/build/test.workdir/test/scenegraph/fx3d/camera/fixedeye/PerspectiveCameraFixedEyeIsolateTest.jtr) >> [test/scenegraph/fx3d/camera/parallel/ParallelCameraIsolateTest.java](file:///Users/jdv/dev/workspace/jfx/jfx-tests/functional/3DTests/build/test.workdir/test/scenegraph/fx3d/camera/parallel/ParallelCameraIsolateTest.jtr) >> [test/scenegraph/fx3d/camera/perspective/PerspectiveCameraIsolateTest.java](file:///Users/jdv/dev/workspace/jfx/jfx-tests/functional/3DTests/build/test.workdir/test/scenegraph/fx3d/camera/perspective/PerspectiveCameraIsolateTest.jtr) >> >> Also i see that some of the camera tests just draw white images, this also >> needs to be verified. >> With this change 41 out of 62 3D tests will run properly. > > Jayathirth D V has updated the pull request incrementally with one additional > commit since the last revision: > > Use common tolerance variable Thanks for fixing these. Looks good to me! ------------- Marked as reviewed by aghaisas (Reviewer). PR Review: https://git.openjdk.org/jfx-tests/pull/5#pullrequestreview-1619189128
