On Fri, 15 Sep 2023 13:12:13 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> - Removed README file >> - Added README.md file with details >> >> For formatted output of README.md - See : >> https://github.com/aghaisas/jfx-tests/tree/update_readme > > README.md line 55: > >> 53: In the absence of a centrally hosted directory of golden images, it is >> imperative that one needs to generate these golden images once and then >> subsequently run the tests. Here are the steps to generate golden images >> 54: >> 55: a) Run the required tests (e.g. functional/SceneGraphTests) as described >> in step (6) above. This test run results in multiple test failures, but >> generates screenshots of test window in `build/images` directory. If >> satisfied with the expected graphical output, these images can be used as >> golden images by copying them to `build/golden/SceneGraphTests/prism/mac` >> directory (for a test run on MacOS). Note - this directory structure needs >> to be created if not present. > > Minor: "MacOS" --> "macOs" actually, it's "macOS": https://en.wikipedia.org/wiki/MacOS :-) ------------- PR Review Comment: https://git.openjdk.org/jfx-tests/pull/11#discussion_r1327368827
