On Fri, 15 Sep 2023 14:28:31 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> README.md line 55: >> >>> 53: In the absence of a centrally hosted directory of golden images, it is >>> imperative that one needs to generate these golden images once and then >>> subsequently run the tests. Here are the steps to generate golden images >>> 54: >>> 55: a) Run the required tests (e.g. functional/SceneGraphTests) as >>> described in step (6) above. This test run results in multiple test >>> failures, but generates screenshots of test window in `build/images` >>> directory. If satisfied with the expected graphical output, these images >>> can be used as golden images by copying them to >>> `build/golden/SceneGraphTests/prism/mac` directory (for a test run on >>> MacOS). Note - this directory structure needs to be created if not present. >> >> Minor: "MacOS" --> "~~macOs~~" "macOS" > > actually, it's "macOS": > > https://en.wikipedia.org/wiki/MacOS > > :-) Very odd. I was sure that I had typed `macOS`. Yes, let's not substitute one typo for another. :) ------------- PR Review Comment: https://git.openjdk.org/jfx-tests/pull/11#discussion_r1327423281
