On Wed, 20 Sep 2023 23:02:32 GMT, Thiago Milczarek Sayao <tsa...@openjdk.org> 
wrote:

>> This replaces obsolete XIM and uses gtk api for IME.
>> Gtk uses [ibus](https://github.com/ibus/ibus)
>> 
>> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative 
>> positioning on `InputMethodRequest`.
>> 
>> [Screencast from 17-09-2023 
>> 21:59:04.webm](https://github.com/openjdk/jfx/assets/30704286/6c398e39-55a3-4420-86a2-beff07b549d3)
>
> Thiago Milczarek Sayao has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Fix @Override

modules/javafx.graphics/src/main/java/javafx/scene/input/InputMethodRequests.java
 line 61:

> 59:      * inserted.
> 60:      *
> 61:      * @param offset the offset within the composed text, if there is

how can an int be null?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1080#discussion_r1338756466

Reply via email to