On Wed, 20 Sep 2023 23:02:32 GMT, Thiago Milczarek Sayao <tsa...@openjdk.org> wrote:
>> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >> positioning on `InputMethodRequest`. >> >> [Screencast from 17-09-2023 >> 21:59:04.webm](https://github.com/openjdk/jfx/assets/30704286/6c398e39-55a3-4420-86a2-beff07b549d3) > > Thiago Milczarek Sayao has updated the pull request incrementally with one > additional commit since the last revision: > > Fix @Override I haven't looked at much of this PR, but I did spot one problem. If a new method really is needed in the InputMethod interface, you will likely need to make it a default method to avoid compatibility issues. In any case, this requires a CSR. I'd like an extra pair of eyes on this. Also, as noted above, it will need a CSR. Oh, I see that Andy already requested a CSR. Thanks! ------------- Changes requested by kcr (Lead). PR Review: https://git.openjdk.org/jfx/pull/1080#pullrequestreview-1646934410 PR Comment: https://git.openjdk.org/jfx/pull/1080#issuecomment-1737610137 PR Comment: https://git.openjdk.org/jfx/pull/1080#issuecomment-1737611151
