On Tue, 31 Oct 2023 11:46:57 GMT, Florian Kirmaier <fkirma...@openjdk.org> 
wrote:

>> The Method javafx.print.getWidth and getHeight returns a double of points.
>> But the values are always rounded to full integers. This causes especially 
>> problems,
>> with mm based Papers.
>> 
>> I asked in the mailing list, with the conclusion (me and John Hendrix) that 
>> is best to just fix this behavior by removing the rounding.
>
> Florian Kirmaier has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   JDK-8316518
>   small change based on codereview

🕶 looks good to me

I think the fix is the right one.

-------------

Marked as reviewed by angorya (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1244#pullrequestreview-1706953801
PR Comment: https://git.openjdk.org/jfx/pull/1244#issuecomment-1787716551

Reply via email to