On Tue, 31 Oct 2023 11:46:57 GMT, Florian Kirmaier <fkirma...@openjdk.org> wrote:
>> The Method javafx.print.getWidth and getHeight returns a double of points. >> But the values are always rounded to full integers. This causes especially >> problems, >> with mm based Papers. >> >> I asked in the mailing list, with the conclusion (me and John Hendrix) that >> is best to just fix this behavior by removing the rounding. > > Florian Kirmaier has updated the pull request incrementally with one > additional commit since the last revision: > > JDK-8316518 > small change based on codereview Sorry about the very lengthy delay here. I've gone back over what little I have left from 11 years ago and I can't find a specific reason for the rounding. My best guess is that it was about "UI", meaning ideally a user would not see values like 611.9985349 If that becomes a problem we can revert this i fwe can't handle it elsewhere. ------------- Marked as reviewed by prr (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/1244#pullrequestreview-1745523007
