On Wed, 13 Dec 2023 19:11:27 GMT, Martin Fox <m...@openjdk.org> wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Account the case of !filtered
>
> modules/javafx.graphics/src/main/native-glass/gtk/glass_window_ime.cpp line
> 175:
>
>> 173: if (im_ctx.ctx != NULL) {
>> 174: g_signal_handlers_disconnect_matched(im_ctx.ctx,
>> G_SIGNAL_MATCH_DATA, 0, 0, NULL, NULL, NULL);
>> 175: g_object_unref(im_ctx.ctx);
>
> If the IM window is visible when the window is closed disableIME() can get
> called twice; I'm seeing debug output being generated. Set im_ctx.ctx to NULL
> here or you'll unref it twice.
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1080#discussion_r1429125936
