On Fri, 5 Jan 2024 17:52:03 GMT, Florian Weimer <[email protected]> wrote:
> 8323078: Incorrect length argument to g_utf8_strlen in pango.c
I wonder if casting to `gssize` would be better than removing the cast
entirely? Are there any platforms on which `gssize` could be a 32-bit int? If
so, there might still be a warning on those platforms? If it's always
guaranteed to be 64-bits, then your fix is fine.
> issue add JDK-8323078
As an FYI, this is not necessary if you include the bug ID in the PR title
(which you did). It's not harmful either, just a no-op.
modules/javafx.graphics/src/main/native-font/pango.c line 427:
> 425: {
> 426: if (!str) return 0;
> 427: return (jlong)g_utf8_strlen((const gchar *)str, pos);
Should this be cast to `(gssize)`?
-------------
PR Review: https://git.openjdk.org/jfx/pull/1320#pullrequestreview-1806653439
PR Comment: https://git.openjdk.org/jfx/pull/1320#issuecomment-1879122792
PR Review Comment: https://git.openjdk.org/jfx/pull/1320#discussion_r1443258905
