On Fri, 5 Jan 2024 18:48:25 GMT, Kevin Rushforth <[email protected]> wrote:
>> Florian Weimer has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new commit since the last revision:
>>
>> 8323078: Incorrect length argument to g_utf8_strlen in pango.c
>
> modules/javafx.graphics/src/main/native-font/pango.c line 427:
>
>> 425: {
>> 426: if (!str) return 0;
>> 427: return (jlong)g_utf8_strlen((const gchar *)str, pos);
>
> Should this be cast to `(gssize)`?
Makes sense, if only for consistency with the `(jlong)` cast of the return type.
(Sorry, I forgot I shouldn't force-push for contributions here …)
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1320#discussion_r1444394820
