On Thu, 11 Jan 2024 18:56:13 GMT, Kevin Rushforth <k...@openjdk.org> wrote:

> Although... I just spotted something. The updated tests use JUnit5 assertions 
> into what is otherwise a JUnit4 test. We generally avoid doing this.

Should we use the JUnit5 `@Test` annotation, or migrate the class to JUnit5? 
The migration is also fine, although some assert need to be switched from 
`assertEquals(text, expected, actual)` -> `assertEquals(expected, actual, text)`

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1329#issuecomment-1887792781

Reply via email to