On Thu, 11 Jan 2024 19:57:21 GMT, Andy Goryachev <[email protected]> wrote:
> Would it be possible to separate the migration from the fix?
Another idea could be to use the full qualified path:
`@org.junit.jupiter.api.Test`. But `@Before` and `@After` are still JUnit 4.
Or we can reduce the change by at least reverting the new line changes? Then
the diff should be much smaller.
> modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewTest.java
> line 3932:
>
>> 3930: }
>> 3931:
>> 3932: @Disabled("Fix not yet developed for TableView")
>
> `@Test` was placed on its own line elsewhere but not in this file?
Hmm, I suggested @EstelonAgarwaen to use the IntelliJ JUnit 5 Migration
functionality. So looks like it is not always putting `@Test` in a new line.
Only when nothing is above it seems?
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1329#issuecomment-1887878588
PR Review Comment: https://git.openjdk.org/jfx/pull/1329#discussion_r1449329912
