On Sat, 27 Jan 2024 17:51:52 GMT, John Hendrikx <[email protected]> wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update documentation on AnimationTimer methods
>
> modules/javafx.graphics/src/main/java/javafx/animation/Animation.java line
> 1008:
>
>> 1006: if (parent != null) {
>> 1007: throw new IllegalStateException("Cannot start when
>> embedded in another animation");
>> 1008: }
>
> Hm, this is going to look really ugly if the caller wasn't on the FX thread.
> The exception won't be thrown, it seems to work, but once run on the FX
> thread, it will just log this instead of breaking the callers flow.
I suppose you can use this as a "trick" to test if the code to shunt it to the
FX thread works (if you don't get the exception immediately, it worked...)
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1352#discussion_r1468541709
