On Tue, 29 Oct 2024 21:40:45 GMT, Nir Lisker <nlis...@openjdk.org> wrote:

> > Also something that just occurred to me, but perhaps I'm late to the party; 
> > with the current API being on `Node` you could call `requestFocusTraversal` 
> > on basically any `Node`, even one that is currently not focused. I'm not 
> > sure if this is intentional or that the API should perhaps only work from 
> > the current focused node.
> 
> I saw this already in the previous PR and thought it's intentional. Even with 
> this method being outside of `Node`, it takes a `Node` argument, which is 
> arbitrary too. If you want to limit it, you'll have to throw or no-op on an 
> unfocused node. I don't think that's necessary.

Well, the API could be on `Scene`, in which case you just call 
`Scene#requestFocusTraversal(Direction)`, as `Scene` knows what the focused 
node is.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1604#issuecomment-2445392199

Reply via email to