On Wed, 30 Oct 2024 15:02:30 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Public focus traversal API for use in custom controls >> >> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md >> >> This work is loosely based on the patch >> https://cr.openjdk.org/~jgiles/8061673/ >> >> And is a scaled down version (with the public traversal policy API removed) >> of >> #1555 > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: > > review comments modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 10447: > 10445: * <p> > 10446: * This method is expected to be called in response to a {@code > KeyEvent}, since the {@code Node} > 10447: * receiving focus will have {@link #focusVisibleProperty() > focusVisible} property set. I think there should be the definite article "the" in front of `{@link #focusVisibleProperty() focusVisible}`. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1604#discussion_r1823342175
