On Mon, 18 Nov 2024 21:13:11 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> correcttion
>
> build.gradle line 706:
>
>> 704: relSuffix = jfxExperimentalFeatureName != "" ?
>> 705: "-${jfxExperimentalFeatureName}" :
>> jfxReleaseSuffix;
>> 706: relOpt = "-${buildTimestamp}"
>
> This will unconditionally add a timestamp to _all_ EA builds of JavaFX, not
> just experimental builds. Changing the version string for EA builds seems out
> of scope for this PR.
>
> Suggestion:
>
> if (jfxExperimentalFeatureName != "") {
> relSuffix = "-${jfxExperimentalFeatureName}"
> relOpt = "-${buildTimestamp}"
> } else {
> relSuffix = jfxReleaseSuffix
> }
Thanks @kevinrushforth , Included the change.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1637#discussion_r1847626483
