On Wed, 20 Nov 2024 23:53:51 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 66 commits: >> >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - hide skin input map >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - whitespace >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - save as >> - removed function handler >> - removed add handler last >> - use focus traversal api >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - ... and 56 more: https://git.openjdk.org/jfx/compare/3a8a5598...e45be7b7 > > modules/jfx.incubator.input/src/main/java/jfx/incubator/scene/control/input/KeyBinding.java > line 123: > >> 121: * and the {@code alt} key modifier ({@code option} on macOS). >> 122: * <p> >> 123: * This method is equivalent to {@link #option(KeyCode)} on macOS. > > Then do we need both? This and similar methods are added for convenience. Every time I code a cross-platform application, I have to think - what is `option` key mapped to? what is `meta`? I don't want to think, or refer to a table (line 49). So what I did was to add mac-specific methods that refer to mac-specific keys. I think it makes my life easier, and hopefully I am not alone. If enough negative feedback comes from the app developers, I am ok with removing these. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1852851662
