On Thu, 21 Nov 2024 20:59:37 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> modules/jfx.incubator.input/src/main/java/jfx/incubator/scene/control/input/KeyBinding.java
>> line 343:
>>
>>> 341: /**
>>> 342: * Creates a {@link Builder} with the specified KeyCode.
>>> 343: * @param character the character
>>
>> Since the type is String what if it is more than one character?
>
> Good point. Added a link to `KeyEvent.getCharacter()`
Does this set the event type to `KEY_TYPED`? If so, then document that. If
not...should it?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1868380986
