> This PR improves the `Tree-/TableRowSkin` code by doing a normal live lookup > for the `fixedCellSize` instead of adding listener just to update > variables(`fixedCellSizeEnabled` and `fixedCellSize`) which can otherwise be > also just lookup'd without the hassle of listeners. > > While this is mostly a cleanup, it does improve the state of the > `Tree-/TableRow`, as when the `TableRowSkinBase` constructor is called, the > variables are not yet set. > > It is also consistent with the other cells, see also > [JDK-8246745](https://bugs.openjdk.org/browse/JDK-8246745). > Helps a bit with [JDK-8185887](https://bugs.openjdk.org/browse/JDK-8185887) > (https://github.com/openjdk/jfx/pull/1644), but as written above, not > required as there is no (visible) effect.
Marius Hanl has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' of https://github.com/openjdk/jfx into 8277000-tree-table-row-skin-live-lookup - Call getFixedCellSize() once - 8277000: Tree-/TableRowSkin: replace listener to fixedCellSize by live lookup ------------- Changes: - all: https://git.openjdk.org/jfx/pull/1645/files - new: https://git.openjdk.org/jfx/pull/1645/files/8206f821..5d5c0c3b Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=1645&range=01 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1645&range=00-01 Stats: 2436 lines in 402 files changed: 879 ins; 435 del; 1122 mod Patch: https://git.openjdk.org/jfx/pull/1645.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1645/head:pull/1645 PR: https://git.openjdk.org/jfx/pull/1645
