On Fri, 24 Jan 2025 19:38:24 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 39 commits: >> >> - Merge branch 'master' into 8299753.resize >> - Merge remote-tracking branch 'origin/master' into 8299753.resize >> - Merge remote-tracking branch 'origin/master' into 8299753.resize >> - in case of hitting min max >> - Merge branch 'master' into 8299753.resize >> - Merge branch 'master' into 8299753.resize >> - Merge remote-tracking branch 'origin/master' into 8299753.resize >> - Merge branch 'master' into 8299753.resize >> - Merge remote-tracking branch 'origin/master' into 8299753.resize >> - Merge remote-tracking branch 'origin/master' into 8299753.resize >> - ... and 29 more: https://git.openjdk.org/jfx/compare/a95151e1...f365f3dd > > modules/javafx.controls/src/main/java/javafx/scene/control/ResizeFeaturesBase.java > line 104: > >> 102: if (c.isSnapToPixel()) { >> 103: double min = c.snapSizeX(col.getMinWidth()); >> 104: double max = RegionHelper.snapInnerSpaceX(c, >> col.getMaxWidth()); > > I'm still not convinced that min and max should be snapped differently (floor > vs ceiling). we will violate the max constraint if we snap to a larger value. so for the max constraint, we should `snapInnerSpace()` which calls the private (?) `Region.snapPortionX()`. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1156#discussion_r1929390436
