On Sat, 25 Jan 2025 00:37:28 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> we will violate the max constraint if we snap to a larger value. >> >> so for the max constraint, we should `snapInnerSpace()` which calls the >> private (?) `Region.snapPortionX()`. > >> we will violate the max constraint if we snap to a larger value. > > Well, it's inherently an over-constrained problem. Conceptually, though, this > does not violate the constraint. When snap-to-pixel is enabled, all values, > including min and max values are snapped to a pixel that can be almost 1 > pixel larger or smaller than it's given value. Within that tolerance, we are > honoring the min and max values. > > It isn't required that we always ceil the min value and floor the max value > (not to mention that doing that is what causes the odd min > max). > > So I don't buy this argument. Is there some other reason to do it? no other reason. are you suggesting to simply `round()`? ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1156#discussion_r1930740267
