On Mon, 24 Feb 2025 20:41:29 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:

>> modules/javafx.graphics/src/main/java/javafx/scene/layout/Region.java line 
>> 2044:
>> 
>>> 2042:      * # content width/heights:
>>> 2043:      *
>>> 2044:      * The space allocated to a child, minus its margins. These are 
>>> never -1.
>> 
>> or always `> 0.0` ?
>
> Yeah, or possibly zero included.  What I meant here is that these are 
> **real** values, and don't have a "special" value `-1` meaning 
> absent/unavailable.

A _very quick_ test with the monkey tester showed it never entered 
`boundedSize()` with zero values, but I can't be sure (I've seen 0's in 
`layoutChildren()`).

The statement about "never -1" is even more suspect below when margins are 
subtracted...

I just wanted to point this out because I am not entirely sure that we'll never 
receive 0 width/height.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1723#discussion_r1968404397

Reply via email to