On Wed, 26 Mar 2025 18:45:49 GMT, Martin Fox <m...@openjdk.org> wrote:
>> modules/javafx.graphics/src/main/java/javafx/application/Platform.java line >> 279: >> >>> 277: * @since 25 >>> 278: */ >>> 279: public static final int MAX_NESTED_EVENT_LOOPS = 200; >> >> I would rather not make this constant public. This is essentially a >> safeguard measure, with the main purpose to prevent the crash and give the >> indication to the application developer that their program has an issue. >> From this perspective, the actual number is not important and should not be >> codified as a public API (but definitely declared as a constant internally). >> >> What do you think? > > I don't think it needs to be public. If we privatize this constant I could > use some guidance on where to place it so that the system test can access it. > Currently there are two system tests that exercise nested event loops > (PlatformTest.java and NestedEventLoopTest.java) and they only rely on public > API's. `PlatformImpl` is probably a good choice, and it's already configured to be accessible to the system tests via `tests/system/src/test/addExports` ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1741#discussion_r2014830866
