On Thu, 27 Mar 2025 17:33:23 GMT, Kevin Rushforth <k...@openjdk.org> wrote:

>> Martin Fox has updated the pull request incrementally with two additional 
>> commits since the last revision:
>> 
>>  - Removed unnecessary import
>>  - The max nested event loop constant is no longer public
>
> modules/javafx.graphics/src/main/java/javafx/application/Platform.java line 
> 305:
> 
>> 303:      * other than the JavaFX Application Thread.
>> 304:      *
>> 305:      * @throws RuntimeException if this call would exceed the maximum
> 
> I wonder if there is a more specific subclass of `RuntimeException` that we 
> could throw? Maybe `IllegalStateException`, which seems the closest in 
> meaning and has the advantage that we already throw it in other cases.

I'll have to wait for others to chime in on that question, I don't have much 
background in this area.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1741#discussion_r2017499898

Reply via email to