On Wed, 5 Mar 2025 18:19:53 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Allows MenuBar to be created in a background thread by delaying >> MenuBarSkin::rebuildUI() call until after the MenuBar becomes a part of the >> scene graph. > > Andy Goryachev has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains six additional > commits since the last revision: > > - Merge remote-tracking branch 'origin/master' into > 8350976.menubarskin.thread.safety > - spelling > - use system menu > - cleanup > - possible fix > - test Marked as reviewed by jdv (Committer). For test verification i was following what i do in JDK of checking out the branch in the PR and without build verify that the test fails and then build the branch(which will build source code change also) and then make sure test passes. Got to know that we need to use -PTEST_ONLY=true in FX to make sure that source code changes are not built when i use gradle to run the test. With this approach i can see that the test fails without product change and passes with it :) ------------- PR Review: https://git.openjdk.org/jfx/pull/1727#pullrequestreview-2734751229 PR Comment: https://git.openjdk.org/jfx/pull/1727#issuecomment-2771426392
