On Mon, 28 Apr 2025 20:38:33 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Jose Pereda has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commits since the last revision: >> >> - Merge branch 'master' into 8207333-contextmenusort >> - remove white space >> - keep column drag lock >> - Prevent drag or start sorting on if popup is triggered, test ctrl+left >> click on macOS >> - Check popupTrigger on mouse pressed too for tableColumnHeaders > > I see a difference in behavior between this PR and the master branch. > Admittedly, the scenario is weird: > > - click and drag a column > - while dragging, right click > > What I sort of expect is the behavior of JTable: the right click completes > the drag to reorder gesture. > > What I see in the master branch is quite weird (testing on macOS): the drag > to reorder gesture completes with the column being repositioned, but the > popup menu flashes on and then off as the right mouse button is released. > > With this PR (again, on macOS) the behavior is different: the popup appears, > at the same time the dragging continues uninterrupted. On Windows, the > position of the highlight indicating the column being dragged jumps to the > original place after right mouse button is released. > > It looks to me as if the original developers did not think of such a scenario > (while JTable ones did). > > We could deal with this scenario in a separate bug, though I think the > Windows case needs to be fixed in this PR. Alternatively, we might want to > handle this weird scenario in this PR. > > What do you think? > > P.S. I can't test on Linux, and we should probably also test in on the latest > Ubuntu as it seems to work slightly different? @andy-goryachev-oracle About this edge case, on macOS it seems better behaviour after this PR: before the highlighting jumps unexpectedly, while after it, the highlighted area is updated smoothly. And I don't see the popup flashing. About Windows, do you mean we should try to reproduce the same behaviour as on macOS? I'm not sure this should be part of this PR (the issue was only on macOS/Linux). ------------- PR Comment: https://git.openjdk.org/jfx/pull/1754#issuecomment-2837019843
