On Mon, 5 May 2025 10:28:09 GMT, Thiago Milczarek Sayao <tsa...@openjdk.org> wrote:
>> This is a continuation to >> [JDK-8236651](https://bugs.openjdk.org/browse/JDK-8236651) and it aims to >> stabilize the linux glass gtk backend. >> >> >> Overall, it has been made more robust within its scope, particularly in >> terms of sizing, positioning, and state management. >> >> List of changes: >> 1. Use GDK for creating Windows. Since we paint directly to the underlying >> XWindow, creating a GtkWidget for the window is unnecessary and results in >> unused GTK resources. Additionally, avoiding the use of a GtkWidget >> eliminates the need for workarounds caused by conflicting GTK behavior—such >> as setting the initial window state, position, or size. >> 2. It aligns with X11's asynchronous behavior by reporting geometry changes >> only upon receiving a configure event, since requests to the window manager >> aren't guaranteed to be honored. However, changes are still reported >> immediately in special cases, such as before the window is realized. For >> example, a request to move the window to (0, 0) might be overridden by the >> window manager, placing it in the top-right corner instead. >> 3. States (fullscreen, maximized and iconify) are now reported back to Java >> when it actually happens rather than immediately (except when not realized); >> 4. When a window is maximized, it will ignore geometry changes and restore >> to the geometry it had prior to being maximized. After some testing, I >> believe this is the best behavior for platform compatibility; >> 5. Unifies the WindowContext class: previously, there were three separate >> classes—two of which (for applets and Java Web Start) were removed, leaving >> only one. However, the supporting infrastructure was still there partially. >> [Unify WindowContext in >> glass-gtk](https://bugs.openjdk.org/browse/JDK-8305768) >> 6. Tests were added and re-enabled to ensure everything works correctly. The >> stage tests now cover various StageStyle configurations, as I found that >> `DECORATED` stages often behave differently from `UNDECORATED` or `UTILITY` >> stages; >> 7. Added Logs for debugging. Enable it with ` -PCONF=DebugNative`; >> 8. Old work-arounds dating back to Ubuntu 16.04 with Compiz were removed. >> >> A simple manual test is provided: >> `java @build/run.args tests/manual/stage/TestStage.java ` >> >> >> List of fixed issues: >> >> 1. [[Linux] Stage.setMaximized() before show() does not >> persist](https://bugs.openjdk.org/browse/JDK-8316425) >> 3. [[Linux] Intermittent test failure in >> IconifyTest.canIconifyDecoratedStage](https://bugs.openjdk.org/browse/JDK-831689... > > Thiago Milczarek Sayao has updated the pull request incrementally with one > additional commit since the last revision: > > Fix TestStage conflicting value listener I still have to do some local testing and run your test apps, but in the meantime I left some minor comments. Overall looks good. modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp line 364: > 362: void WindowContext::notify_repaint() { > 363: if (jview) { > 364: // LOG0("jViewNotifyRepaint\n"); I would either uncomment this log or remove it modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp line 373: > 371: void WindowContext::notify_repaint(GdkRectangle *rect) { > 372: if (jview) { > 373: // LOG4("jViewNotifyRepaint %d, %d, %d, %d\n", rect->x, rect->y, > rect->width, rect->height); As above modules/javafx.graphics/src/main/native-glass/gtk/glass_window.h line 142: > 140: gint initial_state_mask; > 141: protected: > 142: protected: `protected:` is doubled here, you could remove one of those tests/system/src/test/java/test/robot/javafx/stage/StageMixedSizeTest.java line 2: > 1: /* > 2: * Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved. Copyright should be `2024, 2025,` when you're updating an older file ------------- PR Review: https://git.openjdk.org/jfx/pull/1789#pullrequestreview-2811440726 PR Review Comment: https://git.openjdk.org/jfx/pull/1789#discussion_r2075244728 PR Review Comment: https://git.openjdk.org/jfx/pull/1789#discussion_r2075245842 PR Review Comment: https://git.openjdk.org/jfx/pull/1789#discussion_r2075273226 PR Review Comment: https://git.openjdk.org/jfx/pull/1789#discussion_r2075297374
