On Tue, 6 May 2025 11:14:05 GMT, Lukasz Kostyra <lkost...@openjdk.org> wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix TestStage conflicting value listener
>
> modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp line 364:
>
>> 362: void WindowContext::notify_repaint() {
>> 363: if (jview) {
>> 364: // LOG0("jViewNotifyRepaint\n");
>
> I would either uncomment this log or remove it
Done
> modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp line 373:
>
>> 371: void WindowContext::notify_repaint(GdkRectangle *rect) {
>> 372: if (jview) {
>> 373: // LOG4("jViewNotifyRepaint %d, %d, %d, %d\n", rect->x, rect->y,
>> rect->width, rect->height);
>
> As above
Done
> modules/javafx.graphics/src/main/native-glass/gtk/glass_window.h line 142:
>
>> 140: gint initial_state_mask;
>> 141: protected:
>> 142: protected:
>
> `protected:` is doubled here, you could remove one of those
Fixed
> tests/system/src/test/java/test/robot/javafx/stage/StageMixedSizeTest.java
> line 2:
>
>> 1: /*
>> 2: * Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved.
>
> Copyright should be `2024, 2025,` when you're updating an older file
Fixed
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1789#discussion_r2075439188
PR Review Comment: https://git.openjdk.org/jfx/pull/1789#discussion_r2075439387
PR Review Comment: https://git.openjdk.org/jfx/pull/1789#discussion_r2075439688
PR Review Comment: https://git.openjdk.org/jfx/pull/1789#discussion_r2075439889
