On Wed, 7 May 2025 16:41:37 GMT, Pabulaner IV <d...@openjdk.org> wrote:
>> When trying to register an open URI handler when using JavaFX with a native >> menu, this task fails on Mac. >> Either the native menu is not shown or the URIs are not received. >> >> This pull request fixes this issue if AWT is registered after JavaFX, so >> that AWT runs embedded inside JavaFX. >> It fixes this by introducing a native event to AWT, which can be used by >> JavaFX to forward events such as an openURL event. >> >> The test for this pull request is non trivial, as the application needs to >> be installed on the Mac before it can be tested. Therefore the test is >> provided in a separate repository and it needs to be discussed if the test >> is necessary to have inside the JFX repo and if so, how it should be >> integrated. >> >> JDK Pull Request: https://github.com/openjdk/jdk/pull/24379 >> Co-Author: @FlorianKirmaier >> >> Link to the test repo: https://github.com/pabulaner/openurifx > > Pabulaner IV has updated the pull request incrementally with one additional > commit since the last revision: > > 8332947: [macos] java.awt.desktop.OpenURIHandler is not receiving events LGTM. All testing complete. NOTE: The order of integration of the two PRs (AWT and JavaFX) doesn't matter. However, taking one without the other will be ineffective, so wait for both PRs to be approved before integrating either of them. ------------- Marked as reviewed by kcr (Lead). PR Review: https://git.openjdk.org/jfx/pull/1755#pullrequestreview-2844211375
