On Thu, 5 Jun 2025 21:00:49 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 61 commits: >> >> - cleanup >> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api >> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api >> - cleanup >> - removed getStrikeThroughShape >> - caret geometry >> - review comments >> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api >> - review comments >> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api >> - ... and 51 more: https://git.openjdk.org/jfx/compare/9950d33c...de1016be > > modules/javafx.graphics/src/main/java/javafx/scene/text/TextLineInfo.java > line 42: > >> 40: * <li> >> 41: * {@code minY} - the ascent of the line (negative). >> 42: * The ascent of the line is the max ascent of all fonts in the line. > > Shouldn't that be "glyphs" not "fonts"? This definition is copied from `com.sun.javafx.scene.text.TextLine::getBounds` L58. I'll let Phil confirm that, but since it's a max ascent, it might be a function of the font rather than the particular glyphs. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1596#discussion_r2130477383
