On Thu, 5 Jun 2025 21:04:43 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 61 commits: >> >> - cleanup >> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api >> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api >> - cleanup >> - removed getStrikeThroughShape >> - caret geometry >> - review comments >> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api >> - review comments >> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api >> - ... and 51 more: https://git.openjdk.org/jfx/compare/9950d33c...de1016be > > modules/javafx.graphics/src/main/java/javafx/scene/text/CaretInfo.java line > 52: > >> 50: * @return the number of segments representing the caret >> 51: */ >> 52: public abstract int getSegmentCount(); > > Do you think it's worth adding a `List<Rectangle2D>getSegments()` method in > addition to (or instead of) `getSegmentCount` and `getSegmentAt`? Probably unnecessary, because the caret has one segment most of the time. When bidi is involved, the caret might have 2 segments. It will never have 3 or more segments. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1596#discussion_r2130502043
