On Mon, 11 Aug 2025 14:57:00 GMT, Hima Bindu Meda <hm...@openjdk.org> wrote:
>> This PR updates Webkit to v622.1. Verified sanity and build on Mac, Linux >> and windows platforms. No issue seen. > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since the last revision: > > additional fixes for webkit I left a couple questions about your most recent commit. Also, can you add a comment about removing the unused "skia" files (as we discussed offline)? modules/javafx.web/src/main/native/Source/WebCore/Modules/compression/CompressionStreamEncoder.cpp line 81: > 79: #if !PLATFORM(JAVA) > 80: return !m_zstream.getPlatformStream().avail_in && (!m_didFinish || > (m_didFinish && result == Z_STREAM_END)); > 81: #endif I presume this came from upstream code? Was it just missed in the earlier set of updates? In any case, this is a no-op, since it is "ifdef"ed out for our build of WebKit. modules/javafx.web/src/main/native/Source/WebCore/Modules/compression/CompressionStreamEncoder.cpp line 91: > 89: return result != Z_OK && result != Z_STREAM_END && result != > Z_BUF_ERROR; > 90: #endif > 91: return true; How did this even compile previously? Is this file actually included in our build? ------------- PR Review: https://git.openjdk.org/jfx/pull/1865#pullrequestreview-3106412589 PR Review Comment: https://git.openjdk.org/jfx/pull/1865#discussion_r2267123640 PR Review Comment: https://git.openjdk.org/jfx/pull/1865#discussion_r2267125502
