On Mon, 11 Aug 2025 21:40:08 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> modules/javafx.web/src/main/native/Source/WebCore/Modules/compression/CompressionStreamEncoder.cpp >> line 91: >> >>> 89: return result != Z_OK && result != Z_STREAM_END && result != >>> Z_BUF_ERROR; >>> 90: #endif >>> 91: return true; >> >> How did this even compile previously? Is this file actually included in our >> build? > > Independent of how the code compiled before, it was clearly wrong. > > So the more interesting question is: Is `true` the right return value for our > port of WebKit? That appears to be an error return for this method. zlib is not supported on our platform due to zlib dependency, so m_zstream is unused. didDeflateFinish() always returns true to indicate immediate completion with no side effects. m_zstream is never initialized or used in your MYP port No compression work is done at all Returning true simply tells the caller “we’re done,” which is correct for a no-op compression path ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1865#discussion_r2268492223
