On Mon, 13 Oct 2025 12:55:58 GMT, Marius Hanl <[email protected]> wrote:
>> Marius Hanl has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Improve javadoc > > There seems to be an intermediate test failure, maybe a race condition > unrelated to this change: > > > TaskEventTest > cancelledCalledAfterHandler() FAILED > org.opentest4j.AssertionFailedError: expected: <true> but was: <false> > at > app//org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151) > at > app//org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132) > at > app//org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63) > at > app//org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36) > at > app//org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31) > at > app//org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183) > at > app//test.javafx.concurrent.TaskEventTest.cancelledCalledAfterHandler(TaskEventTest.java:410) > @Maran23 In case you missed it, this is pending changes from you. > > 1. I noted some final doc changes in [this comment > above](#discussion_r2455868260). > > 2. I had added an [earlier comment](#issuecomment-3393245504) about > adding your perf test to the PR somewhere under `tests/performance`. On my list, thanks for the reminder! Did not had any time the last days, but I saw all comments and suggestions! ------------- PR Comment: https://git.openjdk.org/jfx/pull/1830#issuecomment-3464164859
