> Addressing the user feedback: > > In RichParagraph you have a note to make getSegments() public. It would be > helpful if it was. > > > Adding two methods to the `RichParagraph` class: > > - getSegmentCount() > - getSegment(int index) > > Decided against exposing a List since it would require additional allocation. > Some of the callers seems to implement special logic when the number of > segments is 0 anyway.
Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into 8371070.enhance - test - expose segments ------------- Changes: - all: https://git.openjdk.org/jfx/pull/1966/files - new: https://git.openjdk.org/jfx/pull/1966/files/27662d6b..62dd46a8 Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=1966&range=01 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1966&range=00-01 Stats: 478 lines in 22 files changed: 387 ins; 16 del; 75 mod Patch: https://git.openjdk.org/jfx/pull/1966.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1966/head:pull/1966 PR: https://git.openjdk.org/jfx/pull/1966
