> Addressing the user feedback:
> 
> In RichParagraph you have a note to make getSegments() public.  It would be 
> helpful if it was.
> 
> 
> Adding two methods to the `RichParagraph` class:
> 
> - getSegmentCount()
> - getSegment(int index)
> 
> Decided against exposing a List since it would require additional allocation. 
>  Some of the callers seems to implement special logic when the number of 
> segments is 0 anyway.

Andy Goryachev has updated the pull request with a new target base due to a 
merge or a rebase. The pull request now contains four commits:

 - Merge branch 'master' into 8371070.enhance
 - Merge branch 'master' into 8371070.enhance
 - test
 - expose segments

-------------

Changes: https://git.openjdk.org/jfx/pull/1966/files
  Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1966&range=02
  Stats: 214 lines in 7 files changed: 141 ins; 43 del; 30 mod
  Patch: https://git.openjdk.org/jfx/pull/1966.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1966/head:pull/1966

PR: https://git.openjdk.org/jfx/pull/1966

Reply via email to