On Fri, 14 Nov 2025 09:30:29 GMT, Marius Hanl <[email protected]> wrote:

>> Ziad El Midaoui has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Add test
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeTableViewTest.java
>  line 6501:
> 
>> 6499:     }
>> 6500: 
>> 6501:     private static double disclosureX(TreeTableRow<String> row) {
> 
> I know IntelliJ makes methods static by default (when extracting), but I 
> don't think it makes sense here

I think it's perfectly fine to have a static method here (and in tests in 
general).

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1971#discussion_r2528340663

Reply via email to