On Fri, 14 Nov 2025 15:56:07 GMT, Ziad El Midaoui <[email protected]>
wrote:
>> When a subtree is moved in a `TreeTableView` , the visuals don’t update
>> until a resize or expand/collapse. The `TreeTableViewSkin` only rebuilds
>> cells when the expanded row count changes.
>> This PR makes the skin to detect structural changes on
>> `childrenModificationEvent` using new variable `treeStructureDirty`, and in
>> `updateItemCount()` call `requestRebuildCells()` to refresh the visuals.
>
> Ziad El Midaoui has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Minor test changes
Two minor comments. Will reapprove once they are fixed.
Test looks good, and gives helpful insights to us in case it fails in the
future. Good job!
modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeTableViewTest.java
line 6474:
> 6472:
> 6473: // Find "item B" row and record its disclosure node indent
> 6474: double xBefore = disclosureIndent(table,4);
Minor: space after the comma:
Suggestion:
double xBefore = disclosureIndent(table, 4);
modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeTableViewTest.java
line 6481:
> 6479: Toolkit.getToolkit().firePulse();
> 6480:
> 6481: double xAfter = disclosureIndent(table,4);
Minor: space after the comma:
Suggestion:
double xAfter = disclosureIndent(table, 4);
-------------
Marked as reviewed by mhanl (Committer).
PR Review: https://git.openjdk.org/jfx/pull/1971#pullrequestreview-3466276428
PR Review Comment: https://git.openjdk.org/jfx/pull/1971#discussion_r2528540782
PR Review Comment: https://git.openjdk.org/jfx/pull/1971#discussion_r2528541414
