On Tue, 25 Nov 2025 14:44:24 GMT, Ambarish Rapte <[email protected]> wrote:
> The `build.gradle` file contains separate tasks for compiling each standalone > metal shader file. > The 5 tasks are combined into a single task. > > Verification: > 1. Verify that build completes successfully, and the 5 **.metal** files are > correctly compiled and 5 **.air** files are generated in directory : > _modules/javafx.graphics/build/msl_ > `ClearRttShaders.air`, `ComputeKernels.air`, `PassThroughVS.air`, > `PhongPS.air`, `PhongVS.air` > 3. Basic sanity testing The build changes look good. I confirm that the output produced by this change is identical to the current master. This is simple enough that one reviewer should be enough, but if @jayathirthrao wants to take a quick look, that might be helpful. ------------- Marked as reviewed by kcr (Lead). PR Review: https://git.openjdk.org/jfx/pull/1984#pullrequestreview-3513063175
